[webkit-reviews] review granted: [Bug 214163] Web Inspector: Tab bar colors of undocked Inspector should match Safari in Big Sur : [Attachment 404277] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 214163: Web Inspector: Tab bar colors of undocked Inspector should match
Safari in Big Sur
https://bugs.webkit.org/show_bug.cgi?id=214163

Attachment 404277: Patch

https://bugs.webkit.org/attachment.cgi?id=404277&action=review




--- Comment #13 from Brian Burg <bburg at apple.com> ---
Comment on attachment 404277
  --> https://bugs.webkit.org/attachment.cgi?id=404277
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404277&action=review

> Source/WebInspectorUI/UserInterface/Views/TabBar.css:151
> +    z-index: calc(var(--tab-bar-border-z-index) + 1);

Does this affect being able to drag to resize the bottom docked frame?

> Source/WebInspectorUI/UserInterface/Views/TabBar.css:173
> +    border-top: 1px solid var(--tab-item-medium-border-color);
> +    border-bottom: 1px solid var(--tab-item-medium-border-color);

Nit: use var(--tab-item-medium-border-style) instead of embedding in the
shorthand rule.

> Source/WebInspectorUI/UserInterface/Views/TabBar.css:176
> +    --tab-item-background: hsl(0, 0%, 90%);

Is this used? I would expect it to always get overridden by the below rules.