[webkit-reviews] review granted: [Bug 214345] [MSE][GStreamer] Break circular reference between SourceBufferPrivateGStreamer and AppendPipeline : [Attachment 404329] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 214345: [MSE][GStreamer] Break circular reference between
SourceBufferPrivateGStreamer and AppendPipeline
https://bugs.webkit.org/show_bug.cgi?id=214345

Attachment 404329: Patch

https://bugs.webkit.org/attachment.cgi?id=404329&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 404329
  --> https://bugs.webkit.org/attachment.cgi?id=404329
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404329&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:57
> -    Ref<SourceBufferPrivateGStreamer> sourceBufferPrivate() { return
m_sourceBufferPrivate.get(); }
> +    SourceBufferPrivateGStreamer& sourceBufferPrivate() { return
m_sourceBufferPrivate; }
>      GstCaps* appsinkCaps() { return m_appsinkCaps.get(); }
>      RefPtr<WebCore::TrackPrivateBase> track() { return m_track; }
>      MediaPlayerPrivateGStreamerMSE* playerPrivate() { return
m_playerPrivate; }

At some point I think we should flag all these that just return object state as
const. I think we would need a separate bug but if you feel like doing it, it
would be great.

Besides, the original code should have returned a const Ref& as you won't touch
the pointer but the object in it.