[webkit-reviews] review denied: [Bug 214315] [css-grid] CSSOM gridTemplateColumns/Rows reports wrong line names when leading implicit tracks are present : [Attachment 404272] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has denied Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 214315: [css-grid] CSSOM gridTemplateColumns/Rows reports wrong line names
when leading implicit tracks are present
https://bugs.webkit.org/show_bug.cgi?id=214315

Attachment 404272: Patch

https://bugs.webkit.org/attachment.cgi?id=404272&action=review




--- Comment #2 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 404272
  --> https://bugs.webkit.org/attachment.cgi?id=404272
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404272&action=review

On a quick look, it seems good. But I'd split it in 2 patches (one for the
refactoring and another for the actual fix). Thanks!

> Source/WebCore/ChangeLog:20
> +	   This patch also renames SmallestTrackStart to ExplicitGridStart.
> +	   The SmallestTrackStart method used to return a signed int which was
> +	   never positive, representing the smallest untranslated start among
all
> +	   grid items, clamped by 0 as a maximum.

Can we do this change on a different patch?

This is basically a refactoring and should have no behavior changes, so we can
land that one first, and then the actual fix for this bug. WDYT?