[webkit-reviews] review denied: [Bug 151613] Changing URL.host should not override port : [Attachment 404255] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 14 20:16:25 PDT 2020


Alex Christensen <achristensen at apple.com> has denied Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 151613: Changing URL.host should not override port
https://bugs.webkit.org/show_bug.cgi?id=151613

Attachment 404255: Patch

https://bugs.webkit.org/attachment.cgi?id=404255&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 404255
  --> https://bugs.webkit.org/attachment.cgi?id=404255
Patch

According to
https://wpt.fyi/results/url/url-setters.html?label=experimental&label=master&al
igned we currently match chrome and Firefox is the only browser following the
spec/passing the wpt.  I think that is justification to not change this unless
Chrome does.

Admittedly Firefox's behavior makes intuitive sense so I'd be willing to change
if there's a consensus.


More information about the webkit-reviews mailing list