[webkit-reviews] review granted: [Bug 214326] Selection is not always clearing when tapping. : [Attachment 404305] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 14 16:40:34 PDT 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 214326: Selection is not always clearing when tapping.
https://bugs.webkit.org/show_bug.cgi?id=214326

Attachment 404305: Patch

https://bugs.webkit.org/attachment.cgi?id=404305&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 404305
  --> https://bugs.webkit.org/attachment.cgi?id=404305
Patch

Can we remove the `!_page->editorState().selectionIsRange` check too?

This is also something we should be able to write a test for.


More information about the webkit-reviews mailing list