[webkit-reviews] review granted: [Bug 126449] [WebGL2] Implement compressedTex{Sub}Image*, copyTexSubImage3D : [Attachment 404287] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 126449: [WebGL2] Implement compressedTex{Sub}Image*, copyTexSubImage3D
https://bugs.webkit.org/show_bug.cgi?id=126449

Attachment 404287: Patch

https://bugs.webkit.org/attachment.cgi?id=404287&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 404287
  --> https://bugs.webkit.org/attachment.cgi?id=404287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404287&action=review

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1311
> +	   synthesizeGLError(
> +	       GraphicsContextGL::INVALID_OPERATION, "compressedTexImage2D",
> +	       "a buffer is bound to PIXEL_UNPACK_BUFFER");

We typically wouldn't split this over lines, but it's ok.