[webkit-reviews] review granted: [Bug 214270] Add support for parsing VP-style codec strings. : [Attachment 404209] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 214270: Add support for parsing VP-style codec strings.
https://bugs.webkit.org/show_bug.cgi?id=214270

Attachment 404209: Patch

https://bugs.webkit.org/attachment.cgi?id=404209&action=review




--- Comment #10 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 404209
  --> https://bugs.webkit.org/attachment.cgi?id=404209
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404209&action=review

> Source/WebCore/platform/graphics/VP9Utilities.cpp:161
> +    if (!transferCharacteristics || (!*transferCharacteristics ||
*transferCharacteristics == 3 || *transferCharacteristics > 18))
> +	   return WTF::nullopt;

As discussed, 2 is undefined.

> LayoutTests/media/vp-codec-parameters.html:130
> +	   consoleWrite('');
> +	   consoleWrite('Test invalid videoFullRangeFlag:');
> +	  
testExpected('internals.parseVPCodecParameters("vp09.02.10.10.01.09.16.01.02")'
, null);
> +	   endTest();

Your parser fails if there is anything after the videoFullRangeFlag, so you
might as well test that as well.