[webkit-reviews] review granted: [Bug 214289] returnEarlyFromInfiniteLoopsForFuzzing and validateDoesGC may fail when used together in the FTL : [Attachment 404200] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 214289: returnEarlyFromInfiniteLoopsForFuzzing and validateDoesGC may fail
when used together in the FTL
https://bugs.webkit.org/show_bug.cgi?id=214289

Attachment 404200: patch

https://bugs.webkit.org/attachment.cgi?id=404200&action=review




--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 404200
  --> https://bugs.webkit.org/attachment.cgi?id=404200
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404200&action=review

r=me with nit.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:14743
> +		      
jit.store32(CCallHelpers::TrustedImm32(DoesGCCheck::encode(true,
DoesGCCheck::Special::Uninitialized)), CCallHelpers::Address(GPRInfo::regT0));

Nit: I think this can be DoesGCCheck(). But maybe I'm missing something.