[webkit-reviews] review granted: [Bug 214272] [iOS] Sometimes unable to type Japanese on docs.google.com : [Attachment 404183] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 214272: [iOS] Sometimes unable to type Japanese on docs.google.com
https://bugs.webkit.org/show_bug.cgi?id=214272

Attachment 404183: Patch

https://bugs.webkit.org/attachment.cgi?id=404183&action=review




--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 404183
  --> https://bugs.webkit.org/attachment.cgi?id=404183
Patch

I _could_ imagine writing an API test for this that directly invokes
-handleKeyWebEvent:withCompletionHandler: inside _WKInputDelegate methods, and
verifies that -handleKeyInputMethodCommandForCurrentEvent is consulted. It
isn’t 100% ideal, but it is a way to exercise this change.