[webkit-reviews] review granted: [Bug 214195] Add OK button to Date/Time form controls. : [Attachment 404188] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 214195: Add OK button to Date/Time form controls.
https://bugs.webkit.org/show_bug.cgi?id=214195

Attachment 404188: Patch

https://bugs.webkit.org/attachment.cgi?id=404188&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 404188
  --> https://bugs.webkit.org/attachment.cgi?id=404188
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404188&action=review

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:86
> +    auto size =  [view
systemLayoutSizeFittingSize:UILayoutFittingCompressedSize];

Extra space after "=" here.

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:88
> +    if (size.width < 250)
> +	   size.width = 250;

std::max might be a nicer way to write this.