[webkit-reviews] review granted: [Bug 214273] Flashes of incorrect scroll position when zooming on quip : [Attachment 404175] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 13 14:45:47 PDT 2020


Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 214273: Flashes of incorrect scroll position when zooming on quip
https://bugs.webkit.org/show_bug.cgi?id=214273

Attachment 404175: Patch

https://bugs.webkit.org/attachment.cgi?id=404175&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 404175
  --> https://bugs.webkit.org/attachment.cgi?id=404175
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404175&action=review

> Source/WebKit/ChangeLog:14
> +	   When refusing such a scroll, we have to inform the web process to
void mismatched ui/web process state,

is "void" "avoid" or something else?

> Source/WebKit/UIProcess/ios/WKContentView.mm:439
> +    sendEvenIfUnchanged:(BOOL)sendEvenIfUnchanged

We really gotta struct this up at some point


More information about the webkit-reviews mailing list