[webkit-reviews] review denied: [Bug 214267] Updated AudioContext constructor according to spec : [Attachment 404168] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 214267: Updated AudioContext constructor according to spec
https://bugs.webkit.org/show_bug.cgi?id=214267

Attachment 404168: Patch

https://bugs.webkit.org/attachment.cgi?id=404168&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 404168
  --> https://bugs.webkit.org/attachment.cgi?id=404168
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404168&action=review

> Source/WebCore/Modules/webaudio/AudioContext.cpp:68
> +    Optional<float> sampleRate = contextOptions.sampleRate;

This local variable is not needed.

> Source/WebCore/Modules/webaudio/AudioContext.cpp:78
> +AudioContext::AudioContext(Document& document, Optional<float> sampleRate)

I suggest passing the whole AudioContextOptions struct here.

> Source/WebCore/Modules/webaudio/BaseAudioContext.h:287
>      explicit BaseAudioContext(Document&);

I suggest passing the whole AudioContextOptions struct here (with a default
value):
explicit BaseAudioContext(Document&, const AudioContextOptions& = { });

> Source/WebCore/Modules/webaudio/BaseAudioContext.h:289
> +    BaseAudioContext(Document&, Optional<float>);

Let's not add yet another constructor.

> Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:49
>      explicit DefaultAudioDestinationNode(BaseAudioContext&);

explicit DefaultAudioDestinationNode(BaseAudioContext&, Optional<float> =
WTF::nullopt);

> Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:50
> +    DefaultAudioDestinationNode(BaseAudioContext&, Optional<float>);

Let's not add another constructor.

>
LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolve
rnode-interface/realtime-conv-expected.txt:3
> +FAIL Executing "test" promise_test: Unhandled rejection with value: object
"SyntaxError: sampleRate is not in range"

Why are we failing this?