[webkit-reviews] review granted: [Bug 214239] Some further streamlining of Gradient handling code : [Attachment 404116] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 12 19:12:05 PDT 2020


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 214239: Some further streamlining of Gradient handling code
https://bugs.webkit.org/show_bug.cgi?id=214239

Attachment 404116: Patch

https://bugs.webkit.org/attachment.cgi?id=404116&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 404116
  --> https://bugs.webkit.org/attachment.cgi?id=404116
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404116&action=review

> Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:150
> +	   gradient->setGradientSpaceTransform(userspaceTransform);
> +
> +	   return { WTFMove(gradient), userspaceTransform };

What is the purpose of storing the userspaceTransform both on the Gradient and
in the GradientData?


More information about the webkit-reviews mailing list