[webkit-reviews] review granted: [Bug 213158] [JSC] String.protoytpe.toLocaleLowerCase's availableLocales HashSet is inefficient : [Attachment 404124] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 213158: [JSC] String.protoytpe.toLocaleLowerCase's availableLocales HashSet
is inefficient
https://bugs.webkit.org/show_bug.cgi?id=213158

Attachment 404124: Patch

https://bugs.webkit.org/attachment.cgi?id=404124&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 404124
  --> https://bugs.webkit.org/attachment.cgi?id=404124
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404124&action=review

> Source/JavaScriptCore/runtime/IntlObjectInlines.h:40
> +    String candidate = locale;

This would be more efficient if it used StringView; no memory allocation when
substring is called.