[webkit-reviews] review granted: [Bug 214238] Building CFNetworkSPI with the macOS Big Sur public SDK fails : [Attachment 404113] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 12 14:29:27 PDT 2020


Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 214238: Building CFNetworkSPI with the macOS Big Sur public SDK fails
https://bugs.webkit.org/show_bug.cgi?id=214238

Attachment 404113: Patch

https://bugs.webkit.org/attachment.cgi?id=404113&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 404113
  --> https://bugs.webkit.org/attachment.cgi?id=404113
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404113&action=review

> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:72
>  #if HAVE(PRECONNECT_PING)
> +
> +#if defined(__OBJC__)

I’d slightly prefer this be && instead of two nested things.


More information about the webkit-reviews mailing list