[webkit-reviews] review denied: [Bug 214043] Building with the public SDK fails (Xcode 11.5 and Big Sur) : [Attachment 404053] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 214043: Building with the public SDK fails (Xcode 11.5 and Big Sur)
https://bugs.webkit.org/show_bug.cgi?id=214043

Attachment 404053: Patch

https://bugs.webkit.org/attachment.cgi?id=404053&action=review




--- Comment #15 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 404053
  --> https://bugs.webkit.org/attachment.cgi?id=404053
Patch

This CFNetwork functionality is not present in current macOS 11 seed versions,
so it's more than an SDK issue. I don't think that we should wait for it to
become available, so disabling it completely seems unavoidable. But we need to
also compile out code in TestWebKitAPI. 

I can think of two approaches. 

1. Disable HAVE_PRECONNECT_PING in PlatformHave.h for public SDK for now. This
would need to reference a bug to re-enable it.

2. Use runtime respondsToSelector checks (TestWebKitAPI part could be somewhat
tricky).