[webkit-reviews] review granted: [Bug 213788] REGRESSION(r260276): Overflow scrolling layers misplaced inside SVG foreign object : [Attachment 404042] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 213788: REGRESSION(r260276): Overflow scrolling layers misplaced inside SVG
foreign object
https://bugs.webkit.org/show_bug.cgi?id=213788

Attachment 404042: Patch

https://bugs.webkit.org/attachment.cgi?id=404042&action=review




--- Comment #8 from zalan <zalan at apple.com> ---
Comment on attachment 404042
  --> https://bugs.webkit.org/attachment.cgi?id=404042
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404042&action=review

> Source/WebCore/dom/Document.h:1275
> +    bool mayHaveRenderedSVGForeignObjects() const { return
m_mayHaveRenderedSVGForeignObjects; }
> +    void setMayHaveRenderedSVGForeignObjects() {
m_mayHaveRenderedSVGForeignObjects = true; }

It's a pity though that we set this bit on the Document and the only client is
the RenderLayer (while we always have a top level layer).