[webkit-reviews] review granted: [Bug 214199] [iOS] Prevent SPI clients from making the minimum layout height or width negative : [Attachment 404003] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 214199: [iOS] Prevent SPI clients from making the minimum layout height or
width negative
https://bugs.webkit.org/show_bug.cgi?id=214199

Attachment 404003: Patch

https://bugs.webkit.org/attachment.cgi?id=404003&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 404003
  --> https://bugs.webkit.org/attachment.cgi?id=404003
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404003&action=review

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2947
> +	   NSLog(@"%s: Error: attempting to override layout parameters with
negative width or height: %@", __PRETTY_FUNCTION__,
NSStringFromCGSize(minimumLayoutSize));

os_log_error, maybe? or even os_log_fault? It is v. v. bad if we get here.