[webkit-reviews] review granted: [Bug 214102] JSRunLoopTimer should use WTF::RunLoop rather than custom CF code : [Attachment 403997] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 214102: JSRunLoopTimer should use WTF::RunLoop rather than custom CF code
https://bugs.webkit.org/show_bug.cgi?id=214102

Attachment 403997: Patch

https://bugs.webkit.org/attachment.cgi?id=403997&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 403997
  --> https://bugs.webkit.org/attachment.cgi?id=403997
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403997&action=review

> Source/JavaScriptCore/runtime/VM.h:1080
> +    WTF::RunLoop& runLoop() const { return m_runLoop.get(); }

Don’t actually need get() here.

> Source/WebCore/bindings/js/CommonVM.cpp:61
> +    RunLoop* runLoop = &RunLoop::current();

Seems like this could just be nullptr since current is the default.