[webkit-reviews] review granted: [Bug 214180] [GTK] MiniBrowser: title of back-forward menu items needs to be truncated when it's too large : [Attachment 403956] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 214180: [GTK] MiniBrowser: title of back-forward menu items needs to be
truncated when it's too large
https://bugs.webkit.org/show_bug.cgi?id=214180

Attachment 403956: Patch

https://bugs.webkit.org/attachment.cgi?id=403956&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 403956
  --> https://bugs.webkit.org/attachment.cgi?id=403956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403956&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:235
> +	       displayTitle[MAX_TITLE - 1] = '.';

I would use an actual ellipsis character (“…”, U+2026) which in
UTF-8 is the sequence of bytes 0xE2, 0x80, 0xA6:

  displayTitle[MAX_TITLE - 3] = 0xE2;
  displayTitle[MAX_TITLE - 2] = 0x80;
  displayTitle[MAX_TITLE - 1] = 0xA6;

��️