[webkit-reviews] review requested: [Bug 213550] [GStreamer][EME][OpenCDM] Implement OpenCDM support : [Attachment 403957] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has asked  for review:
Bug 213550: [GStreamer][EME][OpenCDM] Implement OpenCDM support
https://bugs.webkit.org/show_bug.cgi?id=213550

Attachment 403957: Patch

https://bugs.webkit.org/attachment.cgi?id=403957&action=review




--- Comment #12 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Created attachment 403957

  --> https://bugs.webkit.org/attachment.cgi?id=403957&action=review

Patch

(In reply to Philippe Normand from comment #11)
> Comment on attachment 403689 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=403689&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:292
> > +	 const char* value = g_getenv("WEBKIT_EME_RANK_PRIORITY");
> 
> WEBKIT_GST_...

Done, renamed OpenCDM into Thunder, moved from shared_ptr into the new BoxPtr.

Maybe a final review and we would be good to land.