[webkit-reviews] review denied: [Bug 214150] [GStreamer][1.18] mediastreamsrc element hits assert in gst -core : [Attachment 403892] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 214150: [GStreamer][1.18] mediastreamsrc element hits assert in gst -core
https://bugs.webkit.org/show_bug.cgi?id=214150

Attachment 403892: Patch

https://bugs.webkit.org/attachment.cgi?id=403892&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 403892
  --> https://bugs.webkit.org/attachment.cgi?id=403892
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403892&action=review

> Source/WebCore/ChangeLog:9
> +	   Switch stream and track observers back to refcounted raw GstElement
pointers. The magic of
> +	   GRefPtr is doing more harm than good here.

You state you have a problem but you don't say which one. I guess you have two
extra refs, right? Your problem is that you're explicitly reffing the object
when you're implicitly creating the observers. GRefPtr constructor (which is
implicitly called) already ref_sinks the object you're passing, hence, you
either ref and adopt or you don't ref and let the implicit GRefPtr constructor
do the ref for you.