[webkit-reviews] review granted: [Bug 214156] [WebGL] REGRESSION (r262366): Google search photos do not render, black images : [Attachment 403906] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 214156: [WebGL] REGRESSION (r262366): Google search photos do not render,
black images
https://bugs.webkit.org/show_bug.cgi?id=214156

Attachment 403906: Patch

https://bugs.webkit.org/attachment.cgi?id=403906&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 403906
  --> https://bugs.webkit.org/attachment.cgi?id=403906
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403906&action=review

I think you should be able to write a pretty simple ref test for this.

<canvas>
<div></div>

draw into canvas element
canvas.remove();
divElement.appendChild(canvas);

> Source/WebCore/html/HTMLCanvasElement.cpp:1014
> +    if (insertionType.connectedToDocument)
> +	   addObserver(parentOfInsertedTree.document());

Can it be our document() at this point? I expect this is called after the
insertion has happened.