[webkit-reviews] review granted: [Bug 214122] REGRESSION (r259840): Pressing Esc or ⌘+"." does not dismiss time picker on iOS : [Attachment 403898] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 214122: REGRESSION (r259840): Pressing Esc or ⌘+"." does not dismiss time
picker on iOS
https://bugs.webkit.org/show_bug.cgi?id=214122

Attachment 403898: Patch

https://bugs.webkit.org/attachment.cgi?id=403898&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 403898
  --> https://bugs.webkit.org/attachment.cgi?id=403898
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403898&action=review

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:379
> +    if (elementType == InputType::Time || elementType ==
InputType::DateTimeLocal)

I know this was already here... but is there a better way to know or infer the
right set of types, instead of keeping a list here?