[webkit-reviews] review denied: [Bug 214142] [WTF] Fix PackedAlignedPtr for X86_64 canonical addresses : [Attachment 403873] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 9 10:11:12 PDT 2020


Mark Lam <mark.lam at apple.com> has denied  review:
Bug 214142: [WTF] Fix PackedAlignedPtr for X86_64 canonical addresses
https://bugs.webkit.org/show_bug.cgi?id=214142

Attachment 403873: Patch

https://bugs.webkit.org/attachment.cgi?id=403873&action=review




--- Comment #10 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 403873
  --> https://bugs.webkit.org/attachment.cgi?id=403873
Patch

Taking back the r+.  Looks like you also need to update TEST(WTF_Packed,
AssignAndGet) and the api tests' Packed.cpp.


More information about the webkit-reviews mailing list