[webkit-reviews] review granted: [Bug 214144] Simplify BoxPtr::create : [Attachment 403875] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 9 09:55:22 PDT 2020


Darin Adler <darin at apple.com> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 214144: Simplify BoxPtr::create
https://bugs.webkit.org/show_bug.cgi?id=214144

Attachment 403875: Patch

https://bugs.webkit.org/attachment.cgi?id=403875&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 403875
  --> https://bugs.webkit.org/attachment.cgi?id=403875
Patch

I also think that create is not the right word for something that takes
ownership of an object. Maybe we need to rename those create functions to
adopt.


More information about the webkit-reviews mailing list