[webkit-reviews] review granted: [Bug 213992] Set Restrictions for channelCount, channelCountMode for PannerNode : [Attachment 403864] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 9 08:36:37 PDT 2020


Chris Dumez <cdumez at apple.com> has granted Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 213992: Set Restrictions for channelCount, channelCountMode for PannerNode
https://bugs.webkit.org/show_bug.cgi?id=213992

Attachment 403864: Patch

https://bugs.webkit.org/attachment.cgi?id=403864&action=review




--- Comment #11 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 403864
  --> https://bugs.webkit.org/attachment.cgi?id=403864
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403864&action=review

r=me with nit fix

> Source/WebCore/Modules/webaudio/AudioNode.h:183
> +    ExceptionOr<void> setChannelInterpretation(const ChannelInterpretation);

Drop the const.


More information about the webkit-reviews mailing list