[webkit-reviews] review granted: [Bug 214132] [MSE][GStreamer] Remove m_appendPipelinesMap : [Attachment 403857] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 214132: [MSE][GStreamer] Remove m_appendPipelinesMap
https://bugs.webkit.org/show_bug.cgi?id=214132

Attachment 403857: Patch

https://bugs.webkit.org/attachment.cgi?id=403857&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 403857
  --> https://bugs.webkit.org/attachment.cgi?id=403857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403857&action=review

>
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp
:78
> +void SourceBufferPrivateGStreamer::finishCreation()
> +{
> +    // Initializing the append pipeline must happen after
Ref<SourceBufferPrivateGStreamer> has been constructed and
> +    // adopted, otherwise the makeRef() below would crash on
ASSERT(!m_adoptionIsRequired).
> +    ASSERT(!m_appendPipeline);
> +    m_appendPipeline = WTF::makeUnique<AppendPipeline>(m_client,
makeRef(*this), m_playerPrivate);
> +}

You don't need this, just call relaxAdoptionRequirement() in
SourceBufferPrivateGStreamer::SourceBufferPrivateGStreamer() and you should be
good.