[webkit-reviews] review granted: [Bug 214101] [Windows] Fix errors from calls to uname when not available : [Attachment 403812] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 214101: [Windows] Fix errors from calls to uname when not available
https://bugs.webkit.org/show_bug.cgi?id=214101

Attachment 403812: Patch

https://bugs.webkit.org/attachment.cgi?id=403812&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 403812
  --> https://bugs.webkit.org/attachment.cgi?id=403812
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403812&action=review

Seems OK

> Tools/Scripts/webkitdirs.pm:365
> -	   $output = `uname -m`;
> +	   if (!isWindows()) {
> +	       $output = `uname -m`;
> +	   }

In Perl we would idiomatically write this:

    $output = `uname -m` unless isWindows();

> Tools/Scripts/webkitdirs.pm:369
> +    chomp $output if (defined $output);

No need for those parentheses.