[webkit-reviews] review denied: [Bug 213992] Set Restrictions for channelCount, channelCountMode for PannerNode : [Attachment 403808] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 213992: Set Restrictions for channelCount, channelCountMode for PannerNode
https://bugs.webkit.org/show_bug.cgi?id=213992

Attachment 403808: Patch

https://bugs.webkit.org/attachment.cgi?id=403808&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 403808
  --> https://bugs.webkit.org/attachment.cgi?id=403808
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403808&action=review

Patch does not build in debug.

> Source/WebCore/Modules/webaudio/AudioNode.cpp:299
> +    if (mode != ChannelCountMode::Max && mode !=
ChannelCountMode::ClampedMax && mode != ChannelCountMode::Explicit)

Why not we need this check? These seem to be the only values of
ChannelCountMode.

> Source/WebCore/Modules/webaudio/AudioNode.cpp:317
> +    if (interpretation != ChannelInterpretation::Speakers && interpretation
!= ChannelInterpretation::Discrete)

Ditto.

> Source/WebCore/Modules/webaudio/AudioNode.h:176
> +    unsigned channelCount() { return m_channelCount; }

const

> Source/WebCore/Modules/webaudio/AudioNode.h:179
> +    ChannelCountMode channelCountMode() { return m_channelCountMode; }

const