[webkit-reviews] review granted: [Bug 212379] [WTF] Implement new BoxPtr alias : [Attachment 403778] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 212379: [WTF] Implement new BoxPtr alias
https://bugs.webkit.org/show_bug.cgi?id=212379

Attachment 403778: Patch

https://bugs.webkit.org/attachment.cgi?id=403778&action=review




--- Comment #25 from Darin Adler <darin at apple.com> ---
Comment on attachment 403778
  --> https://bugs.webkit.org/attachment.cgi?id=403778
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403778&action=review

> Source/WTF/wtf/BoxPtr.h:35
> +template<typename T>
> +struct BoxPtrDeleter {

I personally like the style where template is on the same line. Applies to all
the lines in this file.

> Source/WTF/wtf/BoxPtr.h:39
> +#define WTF_DEFINE_BOXPTR_DELETER(typeName, deleterFunction)        \

Seems like this is a little bit hard to use correctly, but let's try this for
now. Also, I suggest just one space before the \ rather than different amounts
on each line.