[webkit-reviews] review granted: [Bug 214042] [iOS] Sharing an <img> element with a base64-encoded URL shares the URL as raw text instead of an image : [Attachment 403743] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 8 09:03:24 PDT 2020
Wenson Hsieh <wenson_hsieh at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 214042: [iOS] Sharing an <img> element with a base64-encoded URL shares the
URL as raw text instead of an image
https://bugs.webkit.org/show_bug.cgi?id=214042
Attachment 403743: Patch
https://bugs.webkit.org/attachment.cgi?id=403743&action=review
--- Comment #12 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 403743
--> https://bugs.webkit.org/attachment.cgi?id=403743
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=403743&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6927
> + NSString *fileName = [NSString stringWithFormat:@"%@.png",
(NSString*)WEB_UI_STRING("Shared Image", "Default name for the file created for
a shared image with no explicit name.")];
Nit - space between NSString and *.
More information about the webkit-reviews
mailing list