[webkit-reviews] review requested: [Bug 212379] [WTF] Implement new BoxPtr alias : [Attachment 403778] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has asked  for review:
Bug 212379: [WTF] Implement new BoxPtr alias
https://bugs.webkit.org/show_bug.cgi?id=212379

Attachment 403778: Patch

https://bugs.webkit.org/attachment.cgi?id=403778&action=review




--- Comment #24 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Created attachment 403778

  --> https://bugs.webkit.org/attachment.cgi?id=403778&action=review

Patch

(In reply to Xabier Rodríguez Calvar from comment #23)
> (In reply to Konstantin Tokarev from comment #22)
> > Comment on attachment 403705 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=403705&action=review
> > 
> > > Source/WTF/wtf/BoxPtr.h:78
> > > +    return !(*lhs == *rhs);
> > 
> > I think it was meant to be implemented via operator== defined above, i.e.
> > 
> >	return !(lhs == rhs);
> 
> Definitely. I guess I should have written tests for that as well and then I
> would realized...

And no, the test intent was there but the test was wrong so it was still
passing. I added another test to test against empty BoxPtrs that was making
former code crash. This works.