[webkit-reviews] review granted: [Bug 213793] REGRESSION (r207558): [Mac] Context clicks on links sometimes result in navigations : [Attachment 403759] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 23:29:35 PDT 2020


Tim Horton <thorton at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 213793: REGRESSION (r207558): [Mac] Context clicks on links sometimes
result in navigations
https://bugs.webkit.org/show_bug.cgi?id=213793

Attachment 403759: Patch

https://bugs.webkit.org/attachment.cgi?id=403759&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 403759
  --> https://bugs.webkit.org/attachment.cgi?id=403759
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403759&action=review

Delightful!

>
Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAP
I.xcscheme:62
> +	 <CommandLineArguments>
> +	    <CommandLineArgument
> +	       argument =
"--gtest_filter="WebKit.ContextMenuControlClick""
> +	       isEnabled = "YES">
> +	    </CommandLineArgument>
> +	 </CommandLineArguments>
> +	 <AdditionalOptions>
> +	 </AdditionalOptions>

Please revert this part!


More information about the webkit-reviews mailing list