[webkit-reviews] review granted: [Bug 214054] Heap Snapshot Object Graph view doesn't get populated in some cases when inspecting a JSContext : [Attachment 403723] patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Christopher Reid
<chris.reid at sony.com>'s request for review:
Bug 214054: Heap Snapshot Object Graph view doesn't get populated in some cases
when inspecting a JSContext
https://bugs.webkit.org/show_bug.cgi?id=214054

Attachment 403723: patch

https://bugs.webkit.org/attachment.cgi?id=403723&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 403723
  --> https://bugs.webkit.org/attachment.cgi?id=403723
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403723&action=review

> Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js:271
> +	   this.heapSnapshot.instancesWithClassName("CallbackGlobalObject",
(instances) => {

While this is fine, it would be nice to show all roots rather than just a
specific few, as these roots may change in the future :)

I believe we could expose a way to iterate `heapSnapshot._nodeOrdinalIsGCRoot`,
calling `HeapSnapshot.prototype.serializeNode` on each.