[webkit-reviews] review granted: [Bug 214059] [Cocoa] Fix adjust-angle-include-paths.sh error seen building ANGLE library : [Attachment 403726] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 18:22:43 PDT 2020


Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 214059: [Cocoa] Fix adjust-angle-include-paths.sh error seen building ANGLE
library
https://bugs.webkit.org/show_bug.cgi?id=214059

Attachment 403726: Patch

https://bugs.webkit.org/attachment.cgi?id=403726&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 403726
  --> https://bugs.webkit.org/attachment.cgi?id=403726
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403726&action=review

rs=me if Dean says so!

> Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj:-4276
> -			outputFileListPaths = (
> -			);
> -			outputPaths = (
> -			);

Hmm, do we have the same for dynamic library target? No dependencies - bad for
XCBuild.


More information about the webkit-reviews mailing list