[webkit-reviews] review requested: [Bug 214063] Modernize FindOptions IPC code : [Attachment 403738] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 16:04:25 PDT 2020


Darin Adler <darin at apple.com> has asked  for review:
Bug 214063: Modernize FindOptions IPC code
https://bugs.webkit.org/show_bug.cgi?id=214063

Attachment 403738: Patch

https://bugs.webkit.org/attachment.cgi?id=403738&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 403738
  --> https://bugs.webkit.org/attachment.cgi?id=403738
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403738&action=review

> Source/WebKit/WebProcess/WebPage/FindController.cpp:299
> +    if (!options.contains(FindOptions::ShowOverlay)
> +	   && !options.contains(FindOptions::ShowFindIndicator))

Like it better as a long line.


More information about the webkit-reviews mailing list