[webkit-reviews] review granted: [Bug 214032] Function didCleanupFullscreencreen() should be called at the end of VideoFullscreenInterfaceAVKit::cleanupFullscreen() : [Attachment 403663] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 09:46:29 PDT 2020


Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 214032: Function didCleanupFullscreencreen() should be called at the end of
VideoFullscreenInterfaceAVKit::cleanupFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=214032

Attachment 403663: Patch

https://bugs.webkit.org/attachment.cgi?id=403663&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 403663
  --> https://bugs.webkit.org/attachment.cgi?id=403663
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403663&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:987
>      [playerController() setHasEnabledVideo:false];
>      [playerController() setHasVideo:false];

Doesn't seem like we should have to call both of these, shouldn't setting
`hasVideo` to false automatically set `hasEnabledVideo` to false? Not new to
this patch, but it would be good to change this in a future cleanup.


More information about the webkit-reviews mailing list