[webkit-reviews] review granted: [Bug 214047] REGRESSION(r263836): [GStreamer] Debug ASSERT hits : [Attachment 403697] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 09:36:36 PDT 2020


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 214047: REGRESSION(r263836): [GStreamer] Debug ASSERT hits
https://bugs.webkit.org/show_bug.cgi?id=214047

Attachment 403697: Patch

https://bugs.webkit.org/attachment.cgi?id=403697&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 403697
  --> https://bugs.webkit.org/attachment.cgi?id=403697
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403697&action=review

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:45
0
> +    ProbeData(GstElement* element, GstStaticPadTemplate* padTemplate,
GRefPtr<GstTagList> tags, const char* trackId)

GRefPtr<GstTagList>&& tags

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:45
3
> +	   , tags(tags)

WTFMove

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:50
1
> +	   auto* data = new ProbeData(GST_ELEMENT_CAST(self), padTemplate,
tags, track->id().utf8().data());

WTFMove


More information about the webkit-reviews mailing list