[webkit-reviews] review granted: [Bug 214010] Get rid of concept of "initial connected gamepads" : [Attachment 403633] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 214010: Get rid of concept of "initial connected gamepads"
https://bugs.webkit.org/show_bug.cgi?id=214010

Attachment 403633: Patch

https://bugs.webkit.org/attachment.cgi?id=403633&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 403633
  --> https://bugs.webkit.org/attachment.cgi?id=403633
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403633&action=review

> Source/WebCore/platform/gamepad/mac/HIDGamepadProvider.cpp:241
> +	   if (!m_inputNotificationTimer.isActive())

I’m confused how this changes things. Aren’t we still in the callback for the
timer that we’re starting here? (Thus if connected stays false we’ll reschedule
it forever?)