[webkit-reviews] review granted: [Bug 214010] Get rid of concept of "initial connected gamepads" : [Attachment 403630] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 214010: Get rid of concept of "initial connected gamepads"
https://bugs.webkit.org/show_bug.cgi?id=214010

Attachment 403630: Patch

https://bugs.webkit.org/attachment.cgi?id=403630&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 403630
  --> https://bugs.webkit.org/attachment.cgi?id=403630
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403630&action=review

> Source/WebCore/platform/gamepad/mac/HIDGamepadProvider.cpp:241
> +	   m_inputNotificationTimer.startOneShot(0_s);

Is this a potentially-forever-looping 0-delay timer‽ Very suspicious.