[webkit-reviews] review granted: [Bug 213906] Fix transform feedback tests : [Attachment 403605] address review feedback and fix non-webgl2 builds

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 213906: Fix transform feedback tests
https://bugs.webkit.org/show_bug.cgi?id=213906

Attachment 403605: address review feedback and fix non-webgl2 builds

https://bugs.webkit.org/attachment.cgi?id=403605&action=review




--- Comment #8 from Dean Jackson <dino at apple.com> ---
Comment on attachment 403605
  --> https://bugs.webkit.org/attachment.cgi?id=403605
address review feedback and fix non-webgl2 builds

View in context: https://bugs.webkit.org/attachment.cgi?id=403605&action=review

> Source/WebCore/html/canvas/WebGLTransformFeedback.cpp:64
> +bool WebGLTransformFeedback::setBoundIndexedTransformFeedbackBuffer(GCGLuint
index, WebGLBuffer* buffer)

You don't check the return value of this. Should it return void?

> Source/WebCore/html/canvas/WebGLTransformFeedback.cpp:78
> +bool WebGLTransformFeedback::getBoundIndexedTransformFeedbackBuffer(GCGLuint
index, WebGLBuffer** outBuffer)
> +{
> +    if (index > m_boundIndexedTransformFeedbackBuffers.size())
> +	   return false;
> +    *outBuffer = m_boundIndexedTransformFeedbackBuffers[index].get();
> +    return true;
> +}

Not necessary right now, but this could return an Optional instead.

> Source/WebCore/html/canvas/WebGLTransformFeedback.h:51
> +    bool getBoundIndexedTransformFeedbackBuffer(GCGLuint index,
WebGLBuffer** outBuffer);

Nit: Don't use "get"