[webkit-reviews] review granted: [Bug 213985] [iPadOS] Unable to change focus between Google Docs windows by tapping : [Attachment 403598] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 6 11:48:18 PDT 2020
Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 213985: [iPadOS] Unable to change focus between Google Docs windows by
tapping
https://bugs.webkit.org/show_bug.cgi?id=213985
Attachment 403598: Patch
https://bugs.webkit.org/attachment.cgi?id=403598&action=review
--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 403598
--> https://bugs.webkit.org/attachment.cgi?id=403598
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=403598&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1504
> + if (nativeWebTouchEvent.isPotentialTap() &&
self.hasHiddenContentEditable && self._hasFocusedElement &&
!self.window.keyWindow)
> + [self.window makeKeyWindow];
Does the test cover all 4 of these changes?
More information about the webkit-reviews
mailing list