[webkit-reviews] review granted: [Bug 213967] [macOS 11] Indeterminate progress bar animation periodically jumps : [Attachment 403558] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 5 11:53:57 PDT 2020


Sam Weinig <sam at webkit.org> has granted Wenson Hsieh <wenson_hsieh at apple.com>'s
request for review:
Bug 213967: [macOS 11] Indeterminate progress bar animation periodically jumps
https://bugs.webkit.org/show_bug.cgi?id=213967

Attachment 403558: Patch

https://bugs.webkit.org/attachment.cgi?id=403558&action=review




--- Comment #6 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 403558
  --> https://bugs.webkit.org/attachment.cgi?id=403558
Patch

Very nice. We could probably optimize things a bit in the future (and make it
match macOS a bit more) if we wanted by having a shared heartbeat timer for all
indeterminate progress indicators, instead of using a timer per-RenderProgress.


More information about the webkit-reviews mailing list