[webkit-reviews] review canceled: [Bug 213967] [macOS 11] Indeterminate progress bar animation periodically jumps : [Attachment 403547] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has canceled Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 213967: [macOS 11] Indeterminate progress bar animation periodically jumps
https://bugs.webkit.org/show_bug.cgi?id=213967

Attachment 403547: Patch

https://bugs.webkit.org/attachment.cgi?id=403547&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 403547
  --> https://bugs.webkit.org/attachment.cgi?id=403547
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403547&action=review

>>> Source/WebCore/rendering/RenderThemeMac.mm:128
>>> +#endif
>> 
>> The CoreUI folks don't really want anyone using kCUIAnimationFrameKey, which
is what requires us to know the number of frames. Can we instead switch to
kCUIAnimationStartTimeKey/kCUIAnimationTimeKey and avoid the problem of needing
to know the number of frames entirely?
> 
> An added benefit of this would be that if we use a shared heartbeat, all the
indeterminate progress indicators in a page will animate in sync, just like in
a normal app.

Yep, this works great!

I wish this meant we could just remove animationDurationForProgressBar and
animationRepeatIntervalForProgressBar, but other ports (Adwaita?) seem to
override this and return a non-zero value. That said, I can at least remove the
hard-coded constants and stop overriding it in RenderThemeMac (and
RenderThemeIOS as well, which for some reason overrides it but returns zero
which is the default anyways ����‍♂️).