[webkit-reviews] review granted: [Bug 213902] [macOS] Adopt AVPlayer.videoRangeOverride : [Attachment 403423] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 213902: [macOS] Adopt AVPlayer.videoRangeOverride
https://bugs.webkit.org/show_bug.cgi?id=213902

Attachment 403423: Patch

https://bugs.webkit.org/attachment.cgi?id=403423&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 403423
  --> https://bugs.webkit.org/attachment.cgi?id=403423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403423&action=review

> Source/WebCore/page/Page.cpp:1160
> +    forEachMediaElement([mode] (HTMLMediaElement& element) {

auto&

> Source/WebCore/page/Page.cpp:1183
> +    forEachMediaElement([mode] (HTMLMediaElement& element) {

auto&

> Source/WebCore/platform/ScreenProperties.h:229
> +	   WTFMove(*preferredDynamicRangeMode)

WTFMove not needed

> Source/WebCore/platform/mac/PlatformScreenMac.mm:158
> +	   screenProperties.screenDataMap.set(displayID, ScreenData {
screenAvailableRect, screenRect, colorSpace, screenDepth,
screenDepthPerComponent, screenSupportsExtendedColor, screenHasInvertedColors,
screenSupportsHighDynamicRange, screenIsMonochrome, displayMask, gpuID,
dynamicRangeMode });

add is probably better since displayID should not be already contained here I
guess.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:979
> +    // If AVPlayer.videoRangeOverride support is present, there's no need to
override HDR moed

s/moed/mode