[webkit-reviews] review granted: [Bug 213913] Add testing infrastructure and SPI declaration for HTTP/2 ping : [Attachment 403426] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 2 18:14:22 PDT 2020
Jer Noble <jer.noble at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 213913: Add testing infrastructure and SPI declaration for HTTP/2 ping
https://bugs.webkit.org/show_bug.cgi?id=213913
Attachment 403426: Patch
https://bugs.webkit.org/attachment.cgi?id=403426&action=review
--- Comment #2 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 403426
--> https://bugs.webkit.org/attachment.cgi?id=403426
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=403426&action=review
r=me with single nit.
> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:77
> +- (void) getUnderlyingHTTPConnectionInfoWithCompletionHandler:(void
(^)(_NSHTTPConnectionInfo *connectionInfo))completionHandler;
Nit: Whitespace between ")" and "get..."
More information about the webkit-reviews
mailing list