[webkit-reviews] review granted: [Bug 213909] GameController.framework soft linking refactoring : [Attachment 403420] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 213909: GameController.framework soft linking refactoring
https://bugs.webkit.org/show_bug.cgi?id=213909

Attachment 403420: Patch

https://bugs.webkit.org/attachment.cgi?id=403420&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 403420
  --> https://bugs.webkit.org/attachment.cgi?id=403420
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403420&action=review

> Source/WebCore/platform/gamepad/cocoa/GameControllerSPI.h:33
> +WTF_EXTERN_C_BEGIN

This should include a fixme with a radar where you ask for the headers to be
fixed.

> Source/WebCore/platform/gamepad/cocoa/GameControllerSoftLink.mm:33
> +SOFT_LINK_FRAMEWORK_FOR_SOURCE(WebCore, GameController)

I think you lost the optionality here?