[webkit-reviews] review granted: [Bug 211522] visualViewport.addEventListener("scroll"*** fires permanently after zoom or orientation change : [Attachment 403390] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 2 13:09:26 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 211522: visualViewport.addEventListener("scroll"*** fires permanently after
zoom or orientation change
https://bugs.webkit.org/show_bug.cgi?id=211522

Attachment 403390: Patch

https://bugs.webkit.org/attachment.cgi?id=403390&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 403390
  --> https://bugs.webkit.org/attachment.cgi?id=403390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403390&action=review

>
LayoutTests/fast/visual-viewport/scroll-event-fired-during-scroll-alone.html:36
> +    }, "Verify that a scroll event gets fired on window.visualViewport when
its offset changes");

This text doesn't seem right. You're verifying that only one scroll event
fires.


More information about the webkit-reviews mailing list