[webkit-reviews] review granted: [Bug 213897] FloatingPointEnvironment::saveMainThreadEnvironment() is not called for macOS Catalyst apps on Apple Silicon : [Attachment 403388] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 2 12:52:14 PDT 2020


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 213897: FloatingPointEnvironment::saveMainThreadEnvironment() is not called
for macOS Catalyst apps on Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=213897

Attachment 403388: Patch

https://bugs.webkit.org/attachment.cgi?id=403388&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 403388
  --> https://bugs.webkit.org/attachment.cgi?id=403388
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403388&action=review

> Source/WebKit/Shared/ios/AuxiliaryProcessIOS.mm:55
>      UNUSED_PARAM(parameters);
>      UNUSED_PARAM(sandboxParameters);

We could remove the argument names now instead of using UNUSED_PARAM.


More information about the webkit-reviews mailing list